Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35916 )
Change subject: util/inteltool: remove unsupported MSRs for 06_9EH ......................................................................
util/inteltool: remove unsupported MSRs for 06_9EH
Change-Id: I5c1e4d20efa7630bf4e6210591790055ead0161c Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M util/inteltool/cpu.c 1 file changed, 0 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/35916/1
diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index 6c72922..245ea22 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -1738,22 +1738,6 @@ { 0x0600, "IA32_DS_AREA" }, { 0x064E, "MSR_PPERF"}, { 0x0653, "MSR_CORE_HDC_RESIDENCY"}, - { 0x0680, "MSR_LASTBRANCH_0_FROM_IP" }, - { 0x0681, "MSR_LASTBRANCH_1_FROM_IP" }, - { 0x0682, "MSR_LASTBRANCH_2_FROM_IP" }, - { 0x0683, "MSR_LASTBRANCH_3_FROM_IP" }, - { 0x0684, "MSR_LASTBRANCH_4_FROM_IP" }, - { 0x0685, "MSR_LASTBRANCH_5_FROM_IP" }, - { 0x0686, "MSR_LASTBRANCH_6_FROM_IP" }, - { 0x0687, "MSR_LASTBRANCH_7_FROM_IP" }, - { 0x0688, "MSR_LASTBRANCH_8_FROM_IP" }, - { 0x0689, "MSR_LASTBRANCH_9_FROM_IP" }, - { 0x068a, "MSR_LASTBRANCH_10_FROM_IP" }, - { 0x068b, "MSR_LASTBRANCH_11_FROM_IP" }, - { 0x068c, "MSR_LASTBRANCH_12_FROM_IP" }, - { 0x068d, "MSR_LASTBRANCH_13_FROM_IP" }, - { 0x068e, "MSR_LASTBRANCH_14_FROM_IP" }, - { 0x068f, "MSR_LASTBRANCH_15_FROM_IP" }, { 0x0690, "MSR_LASTBRANCH_16_FROM_IP" }, { 0x0691, "MSR_LASTBRANCH_17_FROM_IP" }, { 0x0692, "MSR_LASTBRANCH_18_FROM_IP" }, @@ -1770,22 +1754,6 @@ { 0x069D, "MSR_LASTBRANCH_29_FROM_IP" }, { 0x069E, "MSR_LASTBRANCH_30_FROM_IP" }, { 0x069F, "MSR_LASTBRANCH_31_FROM_IP" }, - { 0x06c0, "MSR_LASTBRANCH_0_TO_IP" }, - { 0x06c1, "MSR_LASTBRANCH_1_TO_IP" }, - { 0x06c2, "MSR_LASTBRANCH_2_TO_IP" }, - { 0x06c3, "MSR_LASTBRANCH_3_TO_IP" }, - { 0x06c4, "MSR_LASTBRANCH_4_TO_IP" }, - { 0x06c5, "MSR_LASTBRANCH_5_TO_IP" }, - { 0x06c6, "MSR_LASTBRANCH_6_TO_IP" }, - { 0x06c7, "MSR_LASTBRANCH_7_TO_IP" }, - { 0x06c8, "MSR_LASTBRANCH_8_TO_IP" }, - { 0x06c9, "MSR_LASTBRANCH_9_TO_IP" }, - { 0x06ca, "MSR_LASTBRANCH_10_TO_IP" }, - { 0x06cb, "MSR_LASTBRANCH_11_TO_IP" }, - { 0x06cc, "MSR_LASTBRANCH_12_TO_IP" }, - { 0x06cd, "MSR_LASTBRANCH_13_TO_IP" }, - { 0x06ce, "MSR_LASTBRANCH_14_TO_IP" }, - { 0x06cf, "MSR_LASTBRANCH_15_TO_IP" }, { 0x06d0, "MSR_LASTBRANCH_16_TO_IP" }, { 0x06d1, "MSR_LASTBRANCH_17_TO_IP" }, { 0x06d2, "MSR_LASTBRANCH_18_TO_IP" },
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35916 )
Change subject: util/inteltool: remove unsupported MSRs for 06_9EH ......................................................................
Patch Set 1: Code-Review+2
i find it odd that those cpus only have the registers 16-31, but not 0-15, but this is at least what the intel manual says
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35916 )
Change subject: util/inteltool: remove unsupported MSRs for 06_9EH ......................................................................
util/inteltool: remove unsupported MSRs for 06_9EH
Change-Id: I5c1e4d20efa7630bf4e6210591790055ead0161c Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35916 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/inteltool/cpu.c 1 file changed, 0 insertions(+), 32 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/inteltool/cpu.c b/util/inteltool/cpu.c index 6c72922..245ea22 100644 --- a/util/inteltool/cpu.c +++ b/util/inteltool/cpu.c @@ -1738,22 +1738,6 @@ { 0x0600, "IA32_DS_AREA" }, { 0x064E, "MSR_PPERF"}, { 0x0653, "MSR_CORE_HDC_RESIDENCY"}, - { 0x0680, "MSR_LASTBRANCH_0_FROM_IP" }, - { 0x0681, "MSR_LASTBRANCH_1_FROM_IP" }, - { 0x0682, "MSR_LASTBRANCH_2_FROM_IP" }, - { 0x0683, "MSR_LASTBRANCH_3_FROM_IP" }, - { 0x0684, "MSR_LASTBRANCH_4_FROM_IP" }, - { 0x0685, "MSR_LASTBRANCH_5_FROM_IP" }, - { 0x0686, "MSR_LASTBRANCH_6_FROM_IP" }, - { 0x0687, "MSR_LASTBRANCH_7_FROM_IP" }, - { 0x0688, "MSR_LASTBRANCH_8_FROM_IP" }, - { 0x0689, "MSR_LASTBRANCH_9_FROM_IP" }, - { 0x068a, "MSR_LASTBRANCH_10_FROM_IP" }, - { 0x068b, "MSR_LASTBRANCH_11_FROM_IP" }, - { 0x068c, "MSR_LASTBRANCH_12_FROM_IP" }, - { 0x068d, "MSR_LASTBRANCH_13_FROM_IP" }, - { 0x068e, "MSR_LASTBRANCH_14_FROM_IP" }, - { 0x068f, "MSR_LASTBRANCH_15_FROM_IP" }, { 0x0690, "MSR_LASTBRANCH_16_FROM_IP" }, { 0x0691, "MSR_LASTBRANCH_17_FROM_IP" }, { 0x0692, "MSR_LASTBRANCH_18_FROM_IP" }, @@ -1770,22 +1754,6 @@ { 0x069D, "MSR_LASTBRANCH_29_FROM_IP" }, { 0x069E, "MSR_LASTBRANCH_30_FROM_IP" }, { 0x069F, "MSR_LASTBRANCH_31_FROM_IP" }, - { 0x06c0, "MSR_LASTBRANCH_0_TO_IP" }, - { 0x06c1, "MSR_LASTBRANCH_1_TO_IP" }, - { 0x06c2, "MSR_LASTBRANCH_2_TO_IP" }, - { 0x06c3, "MSR_LASTBRANCH_3_TO_IP" }, - { 0x06c4, "MSR_LASTBRANCH_4_TO_IP" }, - { 0x06c5, "MSR_LASTBRANCH_5_TO_IP" }, - { 0x06c6, "MSR_LASTBRANCH_6_TO_IP" }, - { 0x06c7, "MSR_LASTBRANCH_7_TO_IP" }, - { 0x06c8, "MSR_LASTBRANCH_8_TO_IP" }, - { 0x06c9, "MSR_LASTBRANCH_9_TO_IP" }, - { 0x06ca, "MSR_LASTBRANCH_10_TO_IP" }, - { 0x06cb, "MSR_LASTBRANCH_11_TO_IP" }, - { 0x06cc, "MSR_LASTBRANCH_12_TO_IP" }, - { 0x06cd, "MSR_LASTBRANCH_13_TO_IP" }, - { 0x06ce, "MSR_LASTBRANCH_14_TO_IP" }, - { 0x06cf, "MSR_LASTBRANCH_15_TO_IP" }, { 0x06d0, "MSR_LASTBRANCH_16_TO_IP" }, { 0x06d1, "MSR_LASTBRANCH_17_TO_IP" }, { 0x06d2, "MSR_LASTBRANCH_18_TO_IP" },
-
Felix Held (Code Review) -
Maxim Polyakov (Code Review)