Change in coreboot[master]: Rename ECAM-specific MMCONF Kconfigs

[Stefan Reinauer (Code Review)]

Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Suresh Bellampalli, Morgan Jang, Michal Motyl, Alexander Couzens, Felix Held, Shelley Chen, Furquan Shaikh, Angel Pons, Lance Zhao, Jason Glenesk, Martin Roth, Damien Zammit, Lee Leahy, Marshall Dawson, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57333 )

Change subject: Rename ECAM-specific MMCONF Kconfigs
......................................................................

Patch Set 8:

(4 comments)

This change is ready for review.

File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/57333/comment/ce65a738_d2bd2982 
PS8, Line 501: 
             : config PCI_NO_MMIO_OPS
             : 	bool
             : 	default n
             : 	help
             : 	  If this config is selected, the MMIO access for PCI config
             : 	  space is disabled.
             : 
Are there scenarios where this is different from !PCI_ECAM? At least the previous naming suggested that this is just the opposite of MMCONF_SUPPORT.

Can we drop this, as we are cleaning up here anyways, please? It sounds like a mistake that this ever made it into the tree.

File src/drivers/intel/fsp1_1/romstage.c:

https://review.coreboot.org/c/coreboot/+/57333/comment/43bdaf25_83f5bca1 
PS8, Line 107: if (!CONFIG(PCI_NO_MMIO_OPS))
In the Kconfig we defined:

config MMCONF_BASE_ADDRESS
    hex
    depends on PCI_ECAM

Because of this, we should really check for (CONFIG(PCI_ECAM)) instead of !CONFIG(PCI_NO_MMIO_OPS) because that's what decides whether CONFIG_MMCONF_BASE_ADDRESS exists or not (and this is another indication that PCI_NO_MMIO_OPS should not exist at all)

File src/include/device/pci_mmio_cfg.h:

https://review.coreboot.org/c/coreboot/+/57333/comment/ed6f0849_f88a8c30 
PS8, Line 28: /* this is the ECAM case 
That is now obvious.

File src/soc/intel/quark/Kconfig:

https://review.coreboot.org/c/coreboot/+/57333/comment/f8cc2086_bac2bc23 
PS8, Line 13: select NO_MMCONF_SUPPORT
Some chips seem to define PCI_ECAM now, and others PCI_NO_MMIO_OPS. If we are reworking this part of the code anyways, we should drop one of the two and make the other one explicit.