Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Suresh Bellampalli, Morgan Jang, Michal Motyl, Alexander Couzens, Felix Held, Shelley Chen, Furquan Shaikh, Angel Pons, Lance Zhao, Jason Glenesk, Martin Roth, Damien Zammit, Lee Leahy, Marshall Dawson, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin.
View Change
4 comments:
File src/device/Kconfig:
Patch Set #8, Line 501:
config PCI_NO_MMIO_OPS
bool
default n
help
If this config is selected, the MMIO access for PCI config
space is disabled.
Are there scenarios where this is different from !PCI_ECAM? At least the previous naming suggested that this is just the opposite of MMCONF_SUPPORT.
Can we drop this, as we are cleaning up here anyways, please? It sounds like a mistake that this ever made it into the tree.
File src/drivers/intel/fsp1_1/romstage.c:
Patch Set #8, Line 107: if (!CONFIG(PCI_NO_MMIO_OPS))
In the Kconfig we defined:
config MMCONF_BASE_ADDRESS
hex
depends on PCI_ECAM
Because of this, we should really check for (CONFIG(PCI_ECAM)) instead of !CONFIG(PCI_NO_MMIO_OPS) because that's what decides whether CONFIG_MMCONF_BASE_ADDRESS exists or not (and this is another indication that PCI_NO_MMIO_OPS should not exist at all)
File src/include/device/pci_mmio_cfg.h:
File src/soc/intel/quark/Kconfig:
Patch Set #8, Line 13: select NO_MMCONF_SUPPORT
Some chips seem to define PCI_ECAM now, and others PCI_NO_MMIO_OPS. If we are reworking this part of the code anyways, we should drop one of the two and make the other one explicit.
To view, visit change 57333. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e196a1ed52d131a71f00cba1d93a23e54aca3e2
Gerrit-Change-Number: 57333
Gerrit-PatchSet: 8
Gerrit-Owner: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Huang Jin <huang.jin@intel.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov@gmail.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam@intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin@wiwynn.com>
Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang@wiwynn.com>
Gerrit-Attention: Michal Motyl <michalx.motyl@intel.com>
Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Attention: Shelley Chen <shchen@google.com>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy <leroy.p.leahy@intel.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Attention: Huang Jin <huang.jin@intel.com>
Gerrit-Comment-Date: Tue, 05 Oct 2021 23:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment