Change in coreboot[master]: mb/intel/sm: Add Cr50 support - coreboot-gerrit

1 Mar 2021


      Attention is currently required from: Aamir Bohra.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51086 )
Change subject: mb/intel/sm: Add Cr50 support
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51086/comment/176493cf_9f0c57a8 
PS2, Line 7: sm
nit: I would not shorten `shadowmountain`
File src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/51086/comment/f8ee8792_f730fc68 
PS2, Line 26: H1_PCH_INT_ODL
Should these comments be updated?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33f7427d1675190f65acf14679be93546e6db69a
Gerrit-Change-Number: 51086
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Aamir Bohra aamir.bohra@intel.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 09:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment