Change in ...coreboot[master]: ec/lenovo/h8: Implement ACPI methods to set battery thresholds
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23178 )
Change subject: ec/lenovo/h8: Implement ACPI methods to set battery thresholds ......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG@9 PS24, Line 9: There are two known (yet) different ways to manage battery thresholds. : This patch implements them and adds a way to enable them for : different mainboards.
Are those methods documented somewhere? Is there a specification?
No, it's all reverse engineered AFAIK.
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG@22 PS24, Line 22:
What do the `_24` and `_b0` in the filename mean?
24 and b0 are EC registers used to control thresholds. We don't have a meaningful names for them as they were reverse-engineered.
https://review.coreboot.org/#/c/23178/24//COMMIT_MSG@26 PS24, Line 26: Change-Id: I2a90f9e9b32462b8a5e9bc8d3087ae0fea563ea5
Please put this right above the Signed-off-by lines.
Done
-
Evgeny Zinoviev (Code Review)