Change in coreboot[master]: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec
John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec
After adjustment on fleex I2C0 CLK: 389.9 KHz
BUG=b:141729962 BRANCH=master TEST=emerge-octopus coreboot chromeos-bootimage measure by scope with fleex.
Change-Id: I6a30257b7978cc8899a55f9fd6ffffe01cb2a851 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/35788/1
diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index da4e701..1d1a67a 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -63,6 +63,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 25, + .fall_time_ns = 52, }, .i2c[5] = { .speed = I2C_SPEED_FAST,
Hello Justin TerAvest, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35788
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec
After adjustment on Grob360S I2C0 CLK: 389.9 KHz
BUG=b:141729962 BRANCH=master TEST=emerge-octopus coreboot chromeos-bootimage measure by scope with Grob360S.
Change-Id: I6a30257b7978cc8899a55f9fd6ffffe01cb2a851 Signed-off-by: John Su john_su@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/35788/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG@9 PS2, Line 9: Grob360S What is that?
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
Patch Set 2: Code-Review+2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG@9 PS2, Line 9: Grob360S
What is that?
It is a variant of Fleex.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
Patch Set 2: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35788/2//COMMIT_MSG@9 PS2, Line 9: Grob360S
It is a variant of Fleex.
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35788 )
Change subject: mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec ......................................................................
mb/google/octopus/variants/fleex: Adjust I2C0 CLK to meet spec
After adjustment on Grob360S I2C0 CLK: 389.9 KHz
BUG=b:141729962 BRANCH=master TEST=emerge-octopus coreboot chromeos-bootimage measure by scope with Grob360S.
Change-Id: I6a30257b7978cc8899a55f9fd6ffffe01cb2a851 Signed-off-by: John Su john_su@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35788 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Justin TerAvest teravest@chromium.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/octopus/variants/fleex/overridetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/fleex/overridetree.cb b/src/mainboard/google/octopus/variants/fleex/overridetree.cb index da4e701..1d1a67a 100644 --- a/src/mainboard/google/octopus/variants/fleex/overridetree.cb +++ b/src/mainboard/google/octopus/variants/fleex/overridetree.cb @@ -63,6 +63,8 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 25, + .fall_time_ns = 52, }, .i2c[5] = { .speed = I2C_SPEED_FAST,
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
John Su (Code Review)
-
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Menzel (Code Review)