Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Chris Wang, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49932 )
Change subject: soc/amd/picasso: allow USB_PD port setting override
......................................................................
Patch Set 7:
(4 comments)
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/49932/comment/ae88a962_2e861b74
PS6, Line 52: SAFE_STATE
Can you prefix with USB_PD_RFMUX_ so we don't pollute our namespace.
Done
https://review.coreboot.org/c/coreboot/+/49932/comment/005d06e6_95c82391
PS6, Line 279: de
those settings need to be overwritten, when the type c capable ports are used as type a usb or displ […]
Thanks Felix!
File src/soc/amd/picasso/include/soc/i2c.h:
https://review.coreboot.org/c/coreboot/+/49932/comment/0638133d_9cfc176f
PS6, Line 8:
soc/iomap. […]
The soc/iomap.h has been included in soc/gpio.h I thought
https://review.coreboot.org/c/coreboot/+/49932/comment/24e2bf26_2a554c5d
PS6, Line 24:
nit: could you tabe thes in to align them?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd559b67668846805005a6e00f5a84655310f348
Gerrit-Change-Number: 49932
Gerrit-PatchSet: 7
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 28 Jan 2021 19:00:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment