build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29753 )
Change subject: mb/google/dragonegg: Patch for Audio Enabling ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/varia... File src/mainboard/google/dragonegg/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/varia... PS1, Line 53: /* SPKR_RST_L */ PAD_CFG_GPO(GPP_F19, 1, DEEP), please, no space before tabs
https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/varia... PS1, Line 62: /* I2S0_SCLK */ PAD_CFG_GPO(GPP_R0, 1, DEEP), please, no space before tabs
https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/varia... PS1, Line 63: /* I2S0_SFRM */ PAD_CFG_GPO(GPP_R1, 1, DEEP), please, no space before tabs
https://review.coreboot.org/#/c/29753/1/src/mainboard/google/dragonegg/varia... PS1, Line 64: /* I2S0_TXD */ PAD_CFG_GPO(GPP_R2, 1, DEEP), please, no space before tabs
-
build bot (Jenkins) (Code Review)