Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52662 )
Change subject: sc7180: Add display support for mipi panels ......................................................................
Patch Set 11:
(15 comments)
File src/mainboard/google/trogdor/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/1ab8b7eb_27ab68fe PS11, Line 104: if(CONFIG(TROGDOR_HAS_MIPI_PANEL)) space required before the open parenthesis '('
File src/soc/qualcomm/sc7180/display/dsi.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/3915e9da_e69fac2e PS11, Line 65: write32(&dsi0->trig_ctrl,DSI_DMA_STREAM1 << 8 | DSI_DMA_TRIGGER_SEL); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/befa29f1_35678ef6 PS11, Line 172: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/5febda28_74ae9c44 PS11, Line 210: printk(BIOS_ERR, Invalid vsprintf pointer extension '%pk'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/23eed91a_93d12148 PS11, Line 281: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/4acfb97c_e32a5dd0 PS11, Line 289: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/fc80ffb2_19f90704 PS11, Line 292: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/d3413169_cc68b48d PS11, Line 299: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/1a12d5e0_deea4441 PS11, Line 302: wmb(); memory barrier without comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/8ef43cec_f9baa7ec PS11, Line 319: write32(&dsi0->int_ctrl,0x0); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/db9fde52_7435ea83 PS11, Line 322: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_DMA_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/f6fcd9cd_4c7f829c PS11, Line 325: setbits32(&dsi0->int_ctrl,DSI_CMD_MODE_MDP_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/888b5ecb_0f2cc7e1 PS11, Line 328: setbits32(&dsi0->int_ctrl,DSI_VIDEO_MODE_DONE_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/c2081163_1fb4ac85 PS11, Line 333: setbits32(&dsi0->int_ctrl,DSI_ERROR_AK); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119823): https://review.coreboot.org/c/coreboot/+/52662/comment/3eca8fca_f45def51 PS11, Line 343: if(!pinfo && !pinfo->init_cmd) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)