Derek Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40661 )
Change subject: src/soc/intel/tigerlake: Fix wrong SPD information printed ......................................................................
src/soc/intel/tigerlake: Fix wrong SPD information printed
The SPD infomation printed by print_spd_info() is wrong due to wrong argument. Fix it by passing correct argument.
Change-Id: I0479235849f761b946badb00d6f3e6adb3173b95 Signed-off-by: derek.huang derek.huang@intel.corp-partner.google.com --- M src/soc/intel/tigerlake/meminit.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/40661/1
diff --git a/src/soc/intel/tigerlake/meminit.c b/src/soc/intel/tigerlake/meminit.c index 8664547..e94ccb2 100644 --- a/src/soc/intel/tigerlake/meminit.c +++ b/src/soc/intel/tigerlake/meminit.c @@ -221,8 +221,6 @@ } else { die("Not a valid location(%d) for Memory-down SPD!\n", info->md_spd_loc); } - - print_spd_info((unsigned char *)data); }
void meminit_lpddr4x(FSP_M_CONFIG *mem_cfg, const struct lpddr4x_cfg *board_cfg, @@ -243,6 +241,8 @@ read_md_spd(info, &spd_data, &spd_len); mem_cfg->MemorySpdDataLen = spd_len;
+ print_spd_info((unsigned char *)spd_data); + for (i = 0; i < LPDDR4X_CHANNELS; i++) { if (LPDDR4X_CHANNEL_UNPOPULATED(i, half_populated)) init_spd_upds_empty(mem_cfg, i);
Derek Huang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40661 )
Change subject: src/soc/intel/tigerlake: Fix wrong SPD information printed ......................................................................
Abandoned
fixed by another patch