Attention is currently required from: Harsha B R, Haribalaraman Ramasubramanian, Eric Lai.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69396 )
Change subject: mb/intel/mtlrvp: Configure devicetree and GPIOs for Meteor Lake-P
......................................................................
Patch Set 13:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69396/comment/0694a885_5f0cf92e
PS13, Line 9: Add devicetree and GPIO configuration for Metero Lake-P.
nit: Meteor Lake-P.
File src/mainboard/intel/mtlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/69396/comment/cb739a31_736622ca
PS13, Line 16: select HAVE_ACPI_RESUME
nit: Alphabetically order the Kconfigs.
File src/mainboard/intel/mtlrvp/variants/mtlrvp_p/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/69396/comment/e0772576_3920491c
PS13, Line 1: chip soc/intel/alderlake
meteorlake
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69396
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3173c3f32b36d24467431df3652badd70efeab93
Gerrit-Change-Number: 69396
Gerrit-PatchSet: 13
Gerrit-Owner: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Harsha B R
harsha.b.r@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Harsha B R
harsha.b.r@intel.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 07:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment