Attention is currently required from: Marc Jones, Jonathan Zhang, Angel Pons, Patrick Rudolph.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51452 )
Change subject: soc/intel/xeon_sp/: Fix SMI_LOCK setting
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/xeon_sp/cpx/cpu.c:
https://review.coreboot.org/c/coreboot/+/51452/comment/5c0d7970_bb40d453
PS2, Line 183: pmc_lock_smi();
My preference was to lock it when SMI was enabled, if the platform is set to locking. […]
I think locking all SMM related bits in one place makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbb183ef61ca7330198c1243ecfc2d4df51e652b
Gerrit-Change-Number: 51452
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 15 Mar 2021 22:31:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment