Attention is currently required from: Kane Chen. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63169 )
Change subject: soc/intel/common: Update CSE sub partition update ......................................................................
Patch Set 1:
(6 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/87df2858_29045791 PS1, Line 782: static bool cse_locate_area_as_rdev_rw(const struct cse_bp_info *cse_bp_info, const char *region_name, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/b928a3ca_8f2c9af6 PS1, Line 783: struct region_device *cse_rdev) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/e9052183_e975bf8a PS1, Line 783: struct region_device *cse_rdev) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/8b3f7689_31798fa2 PS1, Line 803: printk(BIOS_DEBUG, "cse_lite: CSE %s partition: offset = 0x%x, size = 0x%x\n", region_name, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/b7217d90_bf44b7d8 PS1, Line 810: struct region_device *target_rdev, const char *region_name, enum bpdt_entry_type type) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144923): https://review.coreboot.org/c/coreboot/+/63169/comment/3346123f_2c3ba4c5 PS1, Line 971: if (!cse_sub_part_get_target_rdev(cse_bp_info, &target_rdev, cse_regions[bp], type)) { line over 96 characters
-
build bot (Jenkins) (Code Review)