Change in coreboot[master]: console: Handle verstage as "first non-bootblock stage" - coreboot-gerrit

14 Jul 2021


      Attention is currently required from: Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56210 )
Change subject: console: Handle verstage as "first non-bootblock stage"
......................................................................
Patch Set 1:
(1 comment)
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/56210/comment/5b9bcd8b_4cc97105 
PS1, Line 15: #endif
...
Okay, I see. […]
Sorry, I don't understand: What difference would it make to use ENV_INITIAL_STAGE
instead of always querying get_uint_option()? Would we lose something if we always
call it?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/56210
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I494a33483e306a049aa0c8137a118644fc28177e
Gerrit-Change-Number: 56210
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 10:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment