Attention is currently required from: Arthur Heymans, Caveh Jalali, Cliff Huang, Felix Singer, Julius Werner, Martin L Roth, Yu-Ping Wu.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77098?usp=email )
Change subject: treewide: Change I2C/SMBUS master/slave to controller/target ......................................................................
Patch Set 5:
(15 comments)
File src/drivers/intel/gma/edid.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/2270457b_f1adea6d : PS5, Line 72: SLAVE TARGET
https://review.coreboot.org/c/coreboot/+/77098/comment/8e41a6d8_f618e8ef : PS5, Line 86: SLAVE TARGET
File src/soc/intel/baytrail/scc.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/3587a134_5ee62fd9 : PS5, Line 63: /* Override Target Path - populate DLL settings. */ This one looks not related to I2C.
File src/soc/intel/common/block/smbus/smbus.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/2793f03e_54023b36 : PS5, Line 25: SLAVE TARGET
File src/soc/nvidia/tegra/i2c.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/12310e5a_fd15b735 : PS5, Line 148: SLAVE TARGET
File src/soc/qualcomm/ipq40xx/i2c.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/ef1dba5b_60b83e01 : PS5, Line 35: QUP_MINICORE_I2C_MASTER Looks like you would like to keep MASTER here?
File src/soc/samsung/exynos5250/i2c.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/33ad9953_f908a446 : PS5, Line 271: SLAVE What about this?
File src/soc/samsung/exynos5420/i2c.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/90409896_27cf7e7a : PS5, Line 145: Master Controller? There is a bunch of other hits in this file for this one.
https://review.coreboot.org/c/coreboot/+/77098/comment/35ff6684_1e6cf4f4 : PS5, Line 344: Master Controller
https://review.coreboot.org/c/coreboot/+/77098/comment/61d1fb32_2c2b2ce1 : PS5, Line 433: Master Should this be Controller instead?
https://review.coreboot.org/c/coreboot/+/77098/comment/9ee2083c_c8ea9db5 : PS5, Line 435: SLV This can still mean SALVE.
https://review.coreboot.org/c/coreboot/+/77098/comment/8ec1eb83_e08afa9b : PS5, Line 619: Master Here, too.
File src/southbridge/intel/bd82x6x/smbus.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/feacae06_3d7dc662 : PS5, Line 23: SLAVE TARGET
File src/southbridge/intel/ibexpeak/smbus.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/a6bd01cb_2e9a64fe : PS5, Line 23: SLAVE TARGET
File src/southbridge/intel/lynxpoint/smbus.c:
https://review.coreboot.org/c/coreboot/+/77098/comment/8a7613f0_f178b6b6 : PS5, Line 23: SLAVE TARGET