Attention is currently required from: Martin L Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68927 )
Change subject: soc/amd/common: Initialize STB Spill-to-DRAM
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/common/block/smu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68927/comment/5ce575d0_c6ae71e1
PS2, Line 2: bootblock-$(CONFIG_SOC_AMD_COMMON_BLOCK_SMU) += smu.c
: romstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_SMU) += smu.c
: ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_SMU) += smu.c
Is there any reason why SMU communication was supported earlier only from SMI? Now that we are sending message to SMU from ramstage are there any possibilities of race condition?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68927
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I547671d2bcfe011566466665b14e151b8ec05430
Gerrit-Change-Number: 68927
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 19:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment