Attention is currently required from: Angel Pons, Arthur Heymans, Keith Hui.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72496 )
Change subject: nb/intel/snb/raminit_mrc.c: Provide default for hook
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72496/comment/25c28506_51e62a80
PS7, Line 9: Of the 13 mainboards that implement mainboard_should_reset_usb() hook,
: only samsung/stumpy does things differently. Turn the majority
: implementation into a __weak default that this one board will override.
Matt, do you have a stumpy?
I do. looking at Stumpy's implementation and the comments, we may be able to drop it since the WA was likely for a 2.x ChromeOS kernel. Want me to test with using the common implementation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3a5a00c0a6b1528e39435784919223d16b3914e
Gerrit-Change-Number: 72496
Gerrit-PatchSet: 7
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Mon, 20 Mar 2023 21:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment