Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56173 )
Change subject: soc/intel/common/irq: Account for single-function devices
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Correct, just PCI_INT_A
Ack.
File src/soc/intel/common/block/irq/irq.c:
https://review.coreboot.org/c/coreboot/+/56173/comment/fc28af5c_17658664
PS1, Line 266: /* Single-function devices must use PIRQ_A */
haha, looks like I misread my own notes (double checked in the BWG, it is INTA, not PIRQ_A). […]
Makes sense. Yeah, INTA requirement should already be satisfied.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b0347c8a2c14413094adf1f9fca380525fb1c8
Gerrit-Change-Number: 56173
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 09 Jul 2021 21:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment