Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41940 )
Change subject: Drop SOC_INTEL_BROADWELL from Kconfig ......................................................................
Drop SOC_INTEL_BROADWELL from Kconfig
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I966f767c904e64d290a6d59b77bb7470c77f7f17 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Makefile.inc M src/drivers/intel/gma/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/purism/librem_bdw/Kconfig D src/soc/intel/broadwell/Kconfig M src/southbridge/intel/common/firmware/Kconfig 8 files changed, 14 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41940/1
diff --git a/Makefile.inc b/Makefile.inc index 86467a6..4f2eeef 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -253,7 +253,7 @@ # "Multiple types (Device object requires either a _HID or _ADR, but not both)" MULTIPLE_TYPES_WARNING = 3073
-ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y) +ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOUTHBRIDGE_INTEL_WILDCATPOINT),y) IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING) else IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) diff --git a/src/drivers/intel/gma/Kconfig b/src/drivers/intel/gma/Kconfig index 635de1c..01a580f 100644 --- a/src/drivers/intel/gma/Kconfig +++ b/src/drivers/intel/gma/Kconfig @@ -72,8 +72,8 @@ def_bool y depends on NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X \ || NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE \ - || NORTHBRIDGE_INTEL_HASWELL \ - || SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ + || NORTHBRIDGE_INTEL_HASWELL || NORTHBRIDGE_INTEL_BROADWELL \ + || SOC_INTEL_SKYLAKE || SOC_INTEL_APOLLOLAKE \ || SOC_INTEL_KABYLAKE || SOC_INTEL_COFFEELAKE \ || SOC_INTEL_WHISKEYLAKE depends on MAINBOARD_USE_LIBGFXINIT || INTEL_GMA_LIBGFXINIT_EDID @@ -103,7 +103,7 @@ default "Broxton" if SOC_INTEL_APOLLOLAKE default "Skylake" if SOC_INTEL_SKYLAKE || SOC_INTEL_KABYLAKE || \ SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE - default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || SOC_INTEL_BROADWELL + default "Haswell" if NORTHBRIDGE_INTEL_HASWELL || NORTHBRIDGE_INTEL_BROADWELL default "Ironlake" if NORTHBRIDGE_INTEL_IRONLAKE || NORTHBRIDGE_INTEL_SANDYBRIDGE default "G45" if NORTHBRIDGE_INTEL_GM45 || NORTHBRIDGE_INTEL_X4X
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 20d2e44..2319598 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -1,7 +1,8 @@
config BOARD_GOOGLE_BASEBOARD_AURON def_bool n - select SOC_INTEL_BROADWELL + select NORTHBRIDGE_INTEL_BROADWELL + select SOUTHBRIDGE_INTEL_WILDCATPOINT select BOARD_ROMSIZE_KB_8192 select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 71143c9..a13d290 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -1,6 +1,7 @@ config BOARD_GOOGLE_BASEBOARD_JECHT def_bool n - select SOC_INTEL_BROADWELL + select NORTHBRIDGE_INTEL_BROADWELL + select SOUTHBRIDGE_INTEL_WILDCATPOINT select BOARD_ROMSIZE_KB_8192 select SUPERIO_ITE_IT8772F select HAVE_ACPI_TABLES diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index 2f6b21e..9f7a20c 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -2,7 +2,8 @@
config BOARD_SPECIFIC_OPTIONS def_bool y - select SOC_INTEL_BROADWELL + select NORTHBRIDGE_INTEL_BROADWELL + select SOUTHBRIDGE_INTEL_WILDCATPOINT select BOARD_ROMSIZE_KB_8192 select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index dcfe78e..7deefa8 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -9,7 +9,8 @@ select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_TPM1 - select SOC_INTEL_BROADWELL + select NORTHBRIDGE_INTEL_BROADWELL + select SOUTHBRIDGE_INTEL_WILDCATPOINT
if BOARD_PURISM_BASEBOARD_LIBREM_BDW
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig deleted file mode 100644 index 2556ee2..0000000 --- a/src/soc/intel/broadwell/Kconfig +++ /dev/null @@ -1,6 +0,0 @@ -config SOC_INTEL_BROADWELL - bool - select NORTHBRIDGE_INTEL_BROADWELL - select SOUTHBRIDGE_INTEL_WILDCATPOINT - help - Intel Broadwell and Haswell ULT support. diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index d827b1a..4b6967e 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -48,7 +48,7 @@ depends on HAVE_ME_BIN && (NORTHBRIDGE_INTEL_IRONLAKE || \ NORTHBRIDGE_INTEL_SANDYBRIDGE || \ NORTHBRIDGE_INTEL_HASWELL || \ - SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || \ + SOUTHBRIDGE_INTEL_WILDCATPOINT || SOC_INTEL_SKYLAKE || \ SOC_INTEL_KABYLAKE || SOC_INTEL_BAYTRAIL || SOC_INTEL_BRASWELL) help Verify the integrity of the supplied Intel ME/TXE firmware before @@ -60,7 +60,7 @@ depends on HAVE_ME_BIN && (NORTHBRIDGE_INTEL_IRONLAKE || \ NORTHBRIDGE_INTEL_SANDYBRIDGE || \ NORTHBRIDGE_INTEL_HASWELL || \ - SOC_INTEL_BROADWELL || SOC_INTEL_SKYLAKE || \ + SOUTHBRIDGE_INTEL_WILDCATPOINT || SOC_INTEL_SKYLAKE || \ SOC_INTEL_KABYLAKE || SOC_INTEL_BAYTRAIL || SOC_INTEL_BRASWELL) help Use me_cleaner to remove all the non-fundamental code from the Intel
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41940
to look at the new patch set (#9).
Change subject: Drop SOC_INTEL_BROADWELL from Kconfig ......................................................................
Drop SOC_INTEL_BROADWELL from Kconfig
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I966f767c904e64d290a6d59b77bb7470c77f7f17 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Makefile.inc M src/drivers/intel/gma/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/purism/librem_bdw/Kconfig D src/soc/intel/broadwell/Kconfig M src/southbridge/intel/common/firmware/Kconfig 8 files changed, 14 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41940/9
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41940
to look at the new patch set (#12).
Change subject: Drop SOC_INTEL_BROADWELL from Kconfig ......................................................................
Drop SOC_INTEL_BROADWELL from Kconfig
With BUILD_TIMELESS=1 but without adding the .config file into the resulting coreboot image, google/auron (Buddy) remains identical.
Change-Id: I966f767c904e64d290a6d59b77bb7470c77f7f17 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Makefile.inc M src/drivers/intel/gma/Kconfig M src/mainboard/google/auron/Kconfig M src/mainboard/google/jecht/Kconfig M src/mainboard/intel/wtm2/Kconfig M src/mainboard/purism/librem_bdw/Kconfig D src/soc/intel/broadwell/Kconfig M src/southbridge/intel/common/firmware/Kconfig 8 files changed, 14 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/41940/12
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41940 )
Change subject: Drop SOC_INTEL_BROADWELL from Kconfig ......................................................................
Abandoned
-
Angel Pons (Code Review)