build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49766 )
Change subject: soc/intel/tgl: Disable S0i3.2 & S0i3.3 substates ......................................................................
Patch Set 12:
(8 comments)
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/49766/comment/9ed34929_4f2e2671 PS12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0)) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/49766/comment/fe0585c0_3f039559 PS12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0)) spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49766/comment/7cc273d9_65b0e220 PS12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49766/comment/ac44255d_f99032fe PS12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/49766/comment/39902f84_6cd5777a PS12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2)) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/49766/comment/69281857_7453ca18 PS12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2)) space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49766/comment/3dc47cdb_8ccd0719 PS12, Line 89: /* If external phy gating is not implemented, S0i3.3/S0i3.4/S0i2.2 are not recommended. */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/49766/comment/f18a94c7_30823ab3 PS12, Line 94: if (is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_BT)) || is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_WIFI)) || is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_ISH))) line over 96 characters