View Change

8 comments:

• File src/soc/intel/tigerlake/fsp_params.c:

  • Patch Set #12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0))

    that open brace { should be on the previous line

  • Patch Set #12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0))

    spaces required around that '==' (ctx:WxV)

  • Patch Set #12, Line 60: if((cpu_id == CPUID_TIGERLAKE_A0) || (cpu_id ==CPUID_TIGERLAKE_B0))

    space required before the open parenthesis '('

  • Patch Set #12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2))

    line over 96 characters

  • Patch Set #12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2))

    that open brace { should be on the previous line

  • Patch Set #12, Line 62: if((mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2) || (mchid == PCI_DEVICE_ID_INTEL_TGL_ID_U_4_2))

    space required before the open parenthesis '('

  • Patch Set #12, Line 89: /* If external phy gating is not implemented, S0i3.3/S0i3.4/S0i2.2 are not recommended. */

    line over 96 characters

  • Patch Set #12, Line 94: if (is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_BT)) || is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_CNVI_WIFI)) || is_dev_enabled(pcidev_path_on_root(PCH_DEVFN_ISH)))

    line over 96 characters

To view, visit change 49766. To unsubscribe, or for help writing mail filters, visit settings.