Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31902 )
Change subject: soc/intel/cannonlake: Fix prev_sleep_state issue
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31902/1/src/soc/intel/cannonlake/pmutil.c
File src/soc/intel/cannonlake/pmutil.c:
https://review.coreboot.org/#/c/31902/1/src/soc/intel/cannonlake/pmutil.c@14...
PS1, Line 146: pmc_clear_suspwrflr
Can you please push a separate CL for this?
https://review.coreboot.org/#/c/31902/1/src/soc/intel/cannonlake/pmutil.c@23...
PS1, Line 236: pmc_clear_suspwrflr
I don't think this is the right place to do this. Probably pmc_init?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9863d52ed3c61b6a160df53f023b0787eaaed68
Gerrit-Change-Number: 31902
Gerrit-PatchSet: 1
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 15 Mar 2019 06:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment