Change in coreboot[master]: driver/usb/acpi: Add power resources for devices on USB ports
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46713 )
Change subject: driver/usb/acpi: Add power resources for devices on USB ports ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
Just to be clear, this is an alternative to the SMI GPIO control, correct?
Yes, the only concern is the OFF method is not getting invoked during shutdown. So we still need the SMI to ensure the sequence during the shutdown.
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46713/2/src/drivers/usb/acpi/usb_ac... PS2, Line 65: * Should we apply Power Resource only for Internal ports. *
Is this a question?
Yes.
-
Karthik Ramasubramanian (Code Review)