Sunwei Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48874 )
Change subject: mb/google/kukui: Add a new config 'Katsu' ......................................................................
mb/google/kukui: Add a new config 'Katsu'
A new board introduced to Kukui family.
BUG=b:176206134 TEST=make # select Katsu BRANCH=kukui
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I09fe2b8f6922dfd2af6424830568466fb98f7aee --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/48874/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 0e3a4dc..f147056 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -59,6 +59,7 @@ default "Esche" if BOARD_GOOGLE_ESCHE default "Burnet" if BOARD_GOOGLE_BURNET default "Fennel" if BOARD_GOOGLE_FENNEL + default "Katsu" if BOARD_GOOGLE_KATSU
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 63cd3e7..072c93bb 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -20,6 +20,10 @@ bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON
+config BOARD_GOOGLE_KATSU + bool "-> Katsu" + select BOARD_GOOGLE_KUKUI_COMMON + comment "Jacuzzi"
config BOARD_GOOGLE_JACUZZI
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48874
to look at the new patch set (#2).
Change subject: mb/google/kukui: Add a new config 'Katsu' ......................................................................
mb/google/kukui: Add a new config 'Katsu'
A new board introduced to Kukui family.
BUG=b:176206134 TEST=make # select Katsu BRANCH=kukui
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I09fe2b8f6922dfd2af6424830568466fb98f7aee --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/48874/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48874 )
Change subject: mb/google/kukui: Add a new config 'Katsu' ......................................................................
Patch Set 2: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48874 )
Change subject: mb/google/kukui: Add a new config 'Katsu' ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48874 )
Change subject: mb/google/kukui: Add a new config 'Katsu' ......................................................................
mb/google/kukui: Add a new config 'Katsu'
A new board introduced to Kukui family.
BUG=b:176206134 TEST=make # select Katsu BRANCH=kukui
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I09fe2b8f6922dfd2af6424830568466fb98f7aee Reviewed-on: https://review.coreboot.org/c/coreboot/+/48874 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 0e3a4dc..ae18263 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -59,6 +59,7 @@ default "Esche" if BOARD_GOOGLE_ESCHE default "Burnet" if BOARD_GOOGLE_BURNET default "Fennel" if BOARD_GOOGLE_FENNEL + default "Katsu" if BOARD_GOOGLE_KATSU
config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 63cd3e7..072c93bb 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -20,6 +20,10 @@ bool "-> Flapjack" select BOARD_GOOGLE_KUKUI_COMMON
+config BOARD_GOOGLE_KATSU + bool "-> Katsu" + select BOARD_GOOGLE_KUKUI_COMMON + comment "Jacuzzi"
config BOARD_GOOGLE_JACUZZI
-
Hung-Te Lin (Code Review) -
Sunwei Li (Code Review)
-
Yu-Ping Wu (Code Review)