Attention is currently required from: Maximilian Brune, Patrick Georgi, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/81410/comment/a7f59a98_03ccbb83 :
PS5, Line 120: depends on (!SOC_SIFIVE_FU540 && !SOC_SIFIVE_FU740)
Wouldn't it be better to handle this locally, e.g. in `soc/sifive/fu540/Kconfig`
```
config RISCV_SOC_HAS_MENVCFG
default n
```
Even if we know that there won't be more cases, listing special cases in common
code is rather discouraged and we wouldn't want such a pattern to spread.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
Gerrit-Change-Number: 81410
Gerrit-PatchSet: 5
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 10:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment