Attention is currently required from: Werner Zeh, Patrick Rudolph, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50594 )
Change subject: src: use ARRAY_SIZE where possible ......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/ironlake/raminit.c:
https://review.coreboot.org/c/coreboot/+/50594/comment/9e441310_bdb32f47 PS2, Line 3773: ARRAY_SIZE(useful_addresses); addr++)
Maybe merge to just one line? Would end up in 96 chars and should fit our rules.
The whole file is a mess. I'd rather fix the coding style in a follow-up.
I made https://review.coreboot.org/q/topic:%22ironlake-raminit%22+status:open a while ago, which splits this file into smaller chunks.
Also, this line is part of a DDR3 SPD reader and parser, and each Intel native raminit implementation has one of them. I would like to factor this out for reusability reasons.
-
Angel Pons (Code Review)