Attention is currently required from: Felix Held, Igor Bagnucki, Krystian Hebel, Maciej Pijanowski, Martin L Roth, Michał Kopeć, Michał Żygowski, Paul Menzel, Sergii Dmytruk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67062?usp=email )
Change subject: soc/ibm/power9/*: add file structure for SOC
......................................................................
Patch Set 33:
(3 comments)
File src/soc/ibm/power9/Kconfig:
https://review.coreboot.org/c/coreboot/+/67062/comment/936719c3_df0b90df :
PS33, Line 5: help
:
We usually put this after the selects.
File src/soc/ibm/power9/Makefile.mk:
PS33:
Add a blank line between each of the three stages for better distinction.
File src/soc/ibm/power9/chip.c:
https://review.coreboot.org/c/coreboot/+/67062/comment/04a1f60a_45da61b0 :
PS33, Line 8: ram_range(dev, /*index=*/0, /*base=*/0, /*size=*/cbmem_top_chipset());
: /* This is for OCC and HOMER images */
: r
Why document the parameters here? The comments make it less readable and one can look up the functions if interested.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67062?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie74b1e34f9aebe151d0fdb0e95c003510fd864c3
Gerrit-Change-Number: 67062
Gerrit-PatchSet: 33
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Igor Bagnucki
bagnucki02@gmail.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Igor Bagnucki
igor.bagnucki@3mdeb.com
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Igor Bagnucki
bagnucki02@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 May 2024 18:55:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment