Change in coreboot[master]: mb/emulation/qemu-i440fx: Reserve low memory

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Duncan Laurie (Code Review)

25 Mar 2020 25 Mar '20

6:27 p.m.

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

mb/emulation/qemu-i440fx: Reserve low memory

Ensure that the low memory is properly reserved so it does not get marked as normal RAM and get wiped or reused by firmware or the kernel. This ensures that the low RSDP is always available for the kernel.

Change-Id: I7295018416229bc957ecbf26f77623a57965557e Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/39834/1

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index b30723d..7e067a4 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -129,6 +129,12 @@ "debugcon"); }

+ /* A segment is legacy VGA region */ + mmio_resource(dev, idx++, 0xa0000 / KiB, (0xc0000 - 0xa0000) / KiB); + + /* C segment to 1MB is reserved RAM (low tables) */ + reserved_ram_resource(dev, idx++, 0xc0000 / KiB, (1*MiB - 0xc0000) / KiB); + if (q35 && ((tomk * 1024) < 0xb0000000)) { /* * Reserve the region between top-of-ram and the

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Furquan Shaikh (Code Review)

25 Mar 25 Mar

6:44 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Wed, 25 Mar 2020 17:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

9:37 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39834/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39834/1//COMMIT_MSG@13 PS1, Line 13: Change-Id: I7295018416229bc957ecbf26f77623a57965557e How can I reproduce the issue?

https://review.coreboot.org/c/coreboot/+/39834/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/northbridge.c:

https://review.coreboot.org/c/coreboot/+/39834/1/src/mainboard/emulation/qem... PS1, Line 136: * Please add spaces around operators.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 25 Mar 2020 20:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Duncan Laurie (Code Review)

26 Mar 26 Mar

10:05 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39834/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39834/1//COMMIT_MSG@13 PS1, Line 13: Change-Id: I7295018416229bc957ecbf26f77623a57965557e

...

How can I reproduce the issue?

Done

https://review.coreboot.org/c/coreboot/+/39834/1/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/northbridge.c:

https://review.coreboot.org/c/coreboot/+/39834/1/src/mainboard/emulation/qem... PS1, Line 136: *

...

Please add spaces around operators.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 26 Mar 2020 21:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Duncan Laurie (Code Review)

10:05 p.m.

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39834

to look at the new patch set (#2).

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

mb/emulation/qemu-i440fx: Reserve low memory

This is only noticed if something wipes the RSDP before the kernel boots, which happens if you use the depthcharge payload and boot in developer mode.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/39834/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Rudolph (Code Review)

27 Mar 27 Mar

9 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 27 Mar 2020 08:00:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:52 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 2 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 27 Mar 2020 12:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

31 Mar 31 Mar

12:41 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39834 )

Change subject: mb/emulation/qemu-i440fx: Reserve low memory ......................................................................

mb/emulation/qemu-i440fx: Reserve low memory

This is only noticed if something wipes the RSDP before the kernel boots, which happens if you use the depthcharge payload and boot in developer mode.

Change-Id: I7295018416229bc957ecbf26f77623a57965557e Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39834 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index b30723d..355f13c 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -129,6 +129,12 @@ "debugcon"); }

+ /* A segment is legacy VGA region */ + mmio_resource(dev, idx++, 0xa0000 / KiB, (0xc0000 - 0xa0000) / KiB); + + /* C segment to 1MB is reserved RAM (low tables) */ + reserved_ram_resource(dev, idx++, 0xc0000 / KiB, (1 * MiB - 0xc0000) / KiB); + if (q35 && ((tomk * 1024) < 0xb0000000)) { /* * Reserve the region between top-of-ram and the

-- To view, visit https://review.coreboot.org/c/coreboot/+/39834 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7295018416229bc957ecbf26f77623a57965557e Gerrit-Change-Number: 39834 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1690

days inactive

1696

days old

coreboot-gerrit@coreboot.org

7 comments

5 participants

tags (0)

participants (5)

Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)