Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86514?usp=email )
Change subject: mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86514/comment/815ab3c0_c6d15984?usp... :
PS6, Line 11:
can you please highlight that you have add 150ms delay before powering off the WWAN?
File src/mainboard/google/brya/variants/uldrenite/gpio.c:
https://review.coreboot.org/c/coreboot/+/86514/comment/b756835b_f71d3faf?usp... :
PS6, Line 236: /* F13 : NC ==> PLTRST_WWAN# */
: PAD_CFG_GPO(GPP_F13, 1, DEEP),
can u move this into romstage as well ?
then you don't need to reconfigure the same GPIOs in ramstage
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86514?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie01019eca7eaa4bbb34dd80aeb65b9b6b08587fd
Gerrit-Change-Number: 86514
Gerrit-PatchSet: 6
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 25 Feb 2025 07:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No