Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/76583?usp=email )
Change subject: mb/starlabs/lite: Put options in CFR cbtable
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/starlabs/lite/cfr.c:
https://review.coreboot.org/c/coreboot/+/76583/comment/0398a438_ca25248d?usp... :
PS14, Line 213: void lb_board(struct lb_header *header)
: {
: char *current = (char *)lb_new_record(header);
: struct lb_cfr *cfr_root = (struct lb_cfr *)current;
:
: cfr_write_setup_menu(cfr_root, sm_root);
: }
this should be: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2
Gerrit-Change-Number: 76583
Gerrit-PatchSet: 15
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Sat, 11 Jan 2025 20:00:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com