Change in coreboot[master]: soc/intel/broadwell/gma.c: Add missing `break` in switch - coreboot-gerrit

31 Jan 2021


      Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50141 )
Change subject: soc/intel/broadwell/gma.c: Add missing `break` in switch
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Me too, but `reg_em4` and `reg_em5` are globals. […]
Just read the Broadwell BIOS spec and there's no mention of the 675 MHz case being special, so I'm pretty sure the fall-through is just human error.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50141
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb979f8a980e1a1e1c712c5d9bc8d94c90376b7f
Gerrit-Change-Number: 50141
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sun, 31 Jan 2021 10:38:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Jacob Garber jgarber1@ualberta.ca
Gerrit-MessageType: comment