Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49077 )
Change subject: mb/clevo/l140cu: Move FSP-M config hook to mainboard level ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/r... File src/mainboard/clevo/cml-u/romstage.c:
https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/r... PS4, Line 6: ry_init_params(FSPM_UPD *memupd) : { : variant_configure_fspm(memupd); : } :
do we really want to create this redirection hell before it's really needed? as long as we have no c […]
That's right, but I find it very irritating that bootblock.c and ramstage.c exist on mb level and romstage.c does not. It makes me feel that romstage.c is missing. So even it's not really necessary here, it's conistent and it's a good "documentation" (or hint?) for the reader that memory init params are configured by each variant.
I can put this into the commit message, if you want.
-
Felix Singer (Code Review)