Attention is currently required from: Karthik Ramasubramanian, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59449 )
Change subject: amdfwtool: clean up psp fw parsing
......................................................................
Patch Set 4:
(2 comments)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/59449/comment/f785146b_51aa1e67
PS2, Line 110: psp_dir_valid_entries
That's totally reasonable, I just wanted to check that this kind of refactoring would be acceptable […]
Done in CB:59584
https://review.coreboot.org/c/coreboot/+/59449/comment/a7b2eb60_d445c755
PS2, Line 178: if (strcmp(fw_name, "PSPBTLDR_WL_FILE") == 0) {
: if (!cb_config->have_whitelist)
: fw_type = AMD_FW_SKIP;
: }
Yes that is on my mind for next cleanup, but again I didn't want it to be in this CL for keep this C […]
Done in CB:59583
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7adb20db7bab73933b457f3449b2d8ce4217b8c
Gerrit-Change-Number: 59449
Gerrit-PatchSet: 4
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 24 Nov 2021 21:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment