Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19942 )
Change subject: purism/librem13v2: Add Kconfig defaults ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19942/1/src/mainboard/purism/librem13v2/Kcon... File src/mainboard/purism/librem13v2/Kconfig:
PS1, Line 76: 0x5c0000
Why override the default defined in soc/intel/skylake?
The default is just a 'safe' default, but the CBFS_SIZE determines the size that CBFS can take without overlapping on the ME/descriptor. The flash is 16MB, there's 10MB used by the ME, and 256KB used by the AMI BIOS NVRAM storage (https://puri.sm/posts/preventing-interference-from-the-old-bios-while-flashi...). If I keep it set to the default of 0x200000, it means that CBFS uses 2MB and there's a 4MB portion of the flash that is left unused.
-
Youness Alaoui (Code Review)