[M] Change in coreboot[master]: soc/intel/ehl: Add EHL MDIO operation

[Mario Scheithauer (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Lean Sheng Tan, Werner Zeh.

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69383 )

Change subject: soc/intel/ehl: Add EHL MDIO operation
......................................................................

Patch Set 7:

(2 comments)

File src/soc/intel/elkhartlake/mdio.c:

https://review.coreboot.org/c/coreboot/+/69383/comment/be400380_f355e626 
PS7, Line 82: .read_resources		= noop_read_resources,
            : 	.set_resources		= noop_set_resources,
> > > This should not be a PCI device, it's a mdio device. […]

static struct mdio_operations ehl_mdio_ops = {
    .read			= mdio_read,
    .write			= mdio_write,
};

//struct device_operations mdio_dev_ops = {
//	.read_resources		= noop_read_resources,
//	.set_resources		= noop_set_resources,
//	.ops_mdio		= &mdio_ops,
//};

void mdio_dev_enable(struct device *dev)
{
//	dev->ops = &mdio_dev_ops;
    dev->ops->ops_mdio = &ehl_mdio_ops;
}

Is that kind of what you mean?

File src/soc/intel/elkhartlake/tsn_gbe.c:

https://review.coreboot.org/c/coreboot/+/69383/comment/52e7ebfc_30509a7b 
PS7, Line 93: .init             = gbe_tsn_init,
            : };
> maybe add . […]

I am not sure what you mean exactly, but mdio_dev_enable(dev) assigns ops_mdio and it is called in gbe_tsn_init().