Change in coreboot[master]: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix
Enable Audio DSP oscillator qualification for S0ix for Helios and Kohaku.
BUG=b:139481313
Change-Id: I1a0911b7967e5823fdce98195420728bd38c80f6 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/hatch/variants/helios/overridetree.cb M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38680/1
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 94639dc..a8ed5ef 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -20,6 +20,9 @@ # No PCIe WiFi register "PcieRpEnable[13]" = "0"
+ # Enable Audio DSP oscillator qualification for S0ix + register "cppmvric2_adsposcdis" = "1" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index ce87469..916d12b 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -20,6 +20,9 @@ # No PCIe WiFi register "PcieRpEnable[13]" = "0"
+ # Enable Audio DSP oscillator qualification for S0ix + register "cppmvric2_adsposcdis" = "1" + # Enable DMIC1 register "PchHdaAudioLinkDmic1" = "1"
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG@9 PS1, Line 9: Helios and Kohaku. Is there some reason we wouldn't want this in the baseboard?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG@9 PS1, Line 9: Helios and Kohaku.
Is there some reason we wouldn't want this in the baseboard?
This would apply for all variants, but the ask here https://partnerissuetracker.corp.google.com/issues/139481313#comment126 for was Kohaku and Helios. Added support for it now.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG@9 PS1, Line 9: Helios and Kohaku.
This would apply for all variants, but the ask here https://partnerissuetracker.corp.google. […]
I think it would be good to do this in baseboard since all variants are going to be affected.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38680
to look at the new patch set (#3).
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix
BUG=b:139481313
Change-Id: I1a0911b7967e5823fdce98195420728bd38c80f6 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38680/3
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG@9 PS1, Line 9: Helios and Kohaku.
I think it would be good to do this in baseboard since all variants are going to be affected.
Ok, agree, the VM support is across the variants. Revised it for baseboard.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 3: Code-Review+2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38680/1//COMMIT_MSG@9 PS1, Line 9: Helios and Kohaku.
Ok, agree, the VM support is across the variants. […]
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38680 )
Change subject: mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix ......................................................................
mb/google/hatch: Enable Audio DSP oscillator qualification for S0ix
BUG=b:139481313
Change-Id: I1a0911b7967e5823fdce98195420728bd38c80f6 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38680 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index e0291bb..f7cf3cd 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -142,6 +142,9 @@ register "PchPmSlpSusMinAssert" = "1" # 500ms register "PchPmSlpAMinAssert" = "3" # 2s
+ # Enable Audio DSP oscillator qualification for S0ix + register "cppmvric2_adsposcdis" = "1" + register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC2)" # Type-C Port 0 register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC2)" # Type-C Port 1 register "usb2_ports[2]" = "USB2_PORT_SHORT(OC3)" # Type-A Port 0
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)