Attention is currently required from: Angel Pons, Michael Niewöhner, Eric Lai, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63126 )
Change subject: Documentation: gpio: Update table as per coreboot guidelines
......................................................................
Patch Set 1:
(3 comments)
File Documentation/getting_started/gpio.md:
https://review.coreboot.org/c/coreboot/+/63126/comment/864d381b_089d8a78
PS1, Line 175: +------------------------+----------------+-------------+-------------+
=====, since it's a header
Ack
https://review.coreboot.org/c/coreboot/+/63126/comment/a5aaafed_69d61830
PS1, Line 177: (GPP: RSMRST,
this won't work - just tested this locally. […]
Ack
https://review.coreboot.org/c/coreboot/+/63126/comment/e600af89_3c663488
PS1, Line 212: 11 - Resume Reset | Warm Reset | - | N |
: | (GPP: Reserved, +----------------+-------------+-------------+
: | GPD:
prefix | needed as above
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63126
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f27f46a9d219098612d8b7747ae26116506fce
Gerrit-Change-Number: 63126
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 28 Mar 2022 03:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment