Change in coreboot[master]: src/mainboard/lenovo/t420/hda_verb.c: Copy HDA verbs from vendor firm...

[Name of user not set (Code Review)]

Attention is currently required from: Peter Lemenkov, Paul Menzel, Patrick Rudolph.
[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 )

Change subject: src/mainboard/lenovo/t420/hda_verb.c: Copy HDA verbs from vendor firmware
......................................................................

Patch Set 2:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/51612/comment/5d690f1c_00dc656c 
PS1, Line 7: src/mainboard/lenovo/t420/hda_verb.c: update codec config
> You can amend a commit (message) using `git commit --amend`. Leave the Change-Id unchanged. […]

Done

https://review.coreboot.org/c/coreboot/+/51612/comment/b3cf5020_48cdcd02 
PS1, Line 14: works flawless both in Linux and Windows.
> That is also information, that is nice to documented either in the commit message and – for the current state – under `Documentation`.

In Documentation/mainboard/lenovo/t420.md?
> No idea, if you know it already *snip*

I can try to dig into it, but it should not stop this change. I have the hardware to try, but my skills sucks - I would need some guidelines. :) I think that the main issue isnt in ALSA. xev gives different output on keypress/keyrelease on vendor and coreboot (also the button led wont work, talking at IRC it could be related to EC).