Attention is currently required from: Andy Ebrahiem, Henry Barnor, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik.
Paul Menzel has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/86480?usp=email )
Change subject: google/fatcat/var/fatcat: Update GSPI0 CS pin
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86480/comment/0a29e902_822f4968?usp... :
PS5, Line 9: TouchPad
touchpad
https://review.coreboot.org/c/coreboot/+/86480/comment/ead27ea7_ecffc442?usp... :
PS5, Line 11: This commit moves the FPS GSPI0-CS signal to GPP_E17, which is an GSPI-0 CS alternative option
Please wrap the line, and add a dot/period at the end.
https://review.coreboot.org/c/coreboot/+/86480/comment/ecfa366a_2f4a0aa9?usp... :
PS5, Line 12:
Please document the schematic version.
https://review.coreboot.org/c/coreboot/+/86480/comment/6ac751ad_e9dfbc7a?usp... :
PS5, Line 14: TEST=build fatcat
No run-time test?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86480?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9d80e163fd4e3e21cc153091bb40763e78d6c595
Gerrit-Change-Number: 86480
Gerrit-PatchSet: 5
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Andy Ebrahiem
ahmet.ebrahiem@9elements.com
Gerrit-Reviewer: Henry Barnor
hbarnor@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Andy Ebrahiem
ahmet.ebrahiem@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Attention: Henry Barnor
hbarnor@chromium.org
Gerrit-Comment-Date: Sat, 22 Feb 2025 06:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes