Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32419
Change subject: mb/google/hatch/: FPMCU not rebooted when DUT reboots ......................................................................
mb/google/hatch/: FPMCU not rebooted when DUT reboots
Add FP_RST_ODL to early GPIO table, configured as low, so that the FPMCU will get reset when coreboot enters bootblock.
BUG=b:130229952 BRANCH=none TEST=Compiles (no Hatch device w/FP to test)
Change-Id: I8a8d8cc2c560f6518337f7500575fdc2265b6347 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/32419/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 7e82b9b..6008910 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -441,6 +441,8 @@
/* GPIOs needed prior to ramstage. */ static const struct pad_config early_gpio_table[] = { + /* A12 : FPMCU_RST_ODL */ + PAD_CFG_GPO(GPP_A12, 0, DEEP), /* B15 : H1_SLAVE_SPI_CS_L */ PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), /* B16 : H1_SLAVE_SPI_CLK */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32419 )
Change subject: mb/google/hatch/: FPMCU not rebooted when DUT reboots ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32419 )
Change subject: mb/google/hatch/: FPMCU not rebooted when DUT reboots ......................................................................
Patch Set 1: Code-Review+1
LGTM2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32419 )
Change subject: mb/google/hatch/: FPMCU not rebooted when DUT reboots ......................................................................
mb/google/hatch/: FPMCU not rebooted when DUT reboots
Add FP_RST_ODL to early GPIO table, configured as low, so that the FPMCU will get reset when coreboot enters bootblock.
BUG=b:130229952 BRANCH=none TEST=Compiles (no Hatch device w/FP to test)
Change-Id: I8a8d8cc2c560f6518337f7500575fdc2265b6347 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32419 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index df1c65e..c12aa64 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -441,6 +441,8 @@
/* GPIOs needed prior to ramstage. */ static const struct pad_config early_gpio_table[] = { + /* A12 : FPMCU_RST_ODL */ + PAD_CFG_GPO(GPP_A12, 0, DEEP), /* B15 : H1_SLAVE_SPI_CS_L */ PAD_CFG_NF(GPP_B15, NONE, DEEP, NF1), /* B16 : H1_SLAVE_SPI_CLK */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32419 )
Change subject: mb/google/hatch/: FPMCU not rebooted when DUT reboots ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32419/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32419/2//COMMIT_MSG@7 PS2, Line 7: FPMCU not rebooted when DUT reboots Please describe the change, and not the problem in the commit message. Maybe:
Reboot FPMCU when DUT reboots
https://review.coreboot.org/#/c/32419/2//COMMIT_MSG@7 PS2, Line 7: / Remove.
https://review.coreboot.org/#/c/32419/2//COMMIT_MSG@9 PS2, Line 9: configured configure