Attention is currently required from: Tarun Tuli, Kangheui Won, Tyler Wang, Nick Vaccaro, Eric Lai.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69790 )
Change subject: mb/google/nissa/var/craask: Disable SAR Proximity Sensor GPIO pin
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/craask/fw_config.c:
File src/mainboard/google/brya/variants/craask/gpio.c:
https://review.coreboot.org/c/coreboot/+/69790/comment/518b0383_db99c3d8
PS3, Line 21: PAD_NC(GPP_H19, NONE),
This is the same as the baseboard so you can just remove it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69790
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b2a2516890b68036e96d1a542e6a10a098cb6a7
Gerrit-Change-Number: 69790
Gerrit-PatchSet: 3
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-CC: Victor Ding
victording@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sun, 20 Nov 2022 23:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment