Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75592?usp=email )
Change subject: soc/amd/cezanne/acpi: use ROOT_BRIDGE macro
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/acpi/soc.asl:
https://review.coreboot.org/c/coreboot/+/75592/comment/dec5f117_78b18232 :
PS3, Line 19: #include <soc/amd/common/acpi/pci_root.asl>
Maybe move this up as a global include since its only adding a macro and not any nodes.
good point. i'll probably wait with pushing an updated patch until the patches before this one are submitted though to not rebase the whole patc train again
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75592?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8f0f1619a71f4ab2051714a9d8c7eb200845390
Gerrit-Change-Number: 75592
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 17:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment