Change in coreboot[master]: sb/intel/bd82x6x: Turn ME PCI register structs into unions - coreboot-gerrit

26 Feb 2021


      Attention is currently required from: Angel Pons, Arthur Heymans, Evgeny Zinoviev, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49993 )
Change subject: sb/intel/bd82x6x: Turn ME PCI register structs into unions
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/southbridge/intel/bd82x6x/me.h:
https://review.coreboot.org/c/coreboot/+/49993/comment/ec9fd42c_b88829bc 
PS6, Line 67: } __packed;
NB. Pack what? It's it's a single word.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a6916e535fbba9f05451d5302261418f950be83
Gerrit-Change-Number: 49993
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Evgeny Zinoviev me@ch1p.io
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 14:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment