Attention is currently required from: Arthur Heymans, Paul Menzel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
Change subject: arch/arm: Build test all arm targets with clang
......................................................................
Patch Set 22:
(1 comment)
File src/soc/nvidia/tegra124/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/69747/comment/3ae6ee98_68345737 :
PS22, Line 25: endif
I feel like it would be better to set CLANG_UNSUPPORTED than to do this tbh. When clang is supported people will assume that there's no practical difference between the two images, but changing optimization settings can make a pretty serious difference in boot speed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8
Gerrit-Change-Number: 69747
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 05 Apr 2024 00:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment