Change in coreboot[master]: sb/intel/lynxpoint: Retype `mei_base_address` pointer - coreboot-gerrit

1 Mar 2021


      Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51035 )
Change subject: sb/intel/lynxpoint: Retype `mei_base_address` pointer
......................................................................
Patch Set 2:
(2 comments)
File src/southbridge/intel/lynxpoint/me.c:
https://review.coreboot.org/c/coreboot/+/51035/comment/b88b93bf_09d89d2a 
PS1, Line 541: 0xf
...
There's a macro for that 0xf mask
Done
https://review.coreboot.org/c/coreboot/+/51035/comment/43ff2465_8eaa5833 
PS1, Line 541: 	mei_base_address = (u8 *)(pci_read_config32(PCH_ME_DEV, PCI_BASE_ADDRESS_0) & ~0xf);
...
Please cast to `uintptr_t` first.
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fdcc6b1ffde1b0701218a3bd0a61ab827081b5
Gerrit-Change-Number: 51035
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 01 Mar 2021 21:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment