Change in coreboot[master]: Kconfig: Change STACK_SIZE value to decimal

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

25 Sep 2019 25 Sep '19

8:49 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: Kconfig: Change STACK_SIZE value to decimal ......................................................................

Kconfig: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/Kconfig M src/soc/cavium/cn81xx/Kconfig 2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/1

diff --git a/src/Kconfig b/src/Kconfig index a1c016e..2be653e 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -471,9 +471,9 @@ default 0x4000

config STACK_SIZE - hex - default 0x1000 if ARCH_X86 - default 0x0 + int + default 4096 if ARCH_X86 + default 0

config MAX_CPUS int diff --git a/src/soc/cavium/cn81xx/Kconfig b/src/soc/cavium/cn81xx/Kconfig index f64350e..900cade 100644 --- a/src/soc/cavium/cn81xx/Kconfig +++ b/src/soc/cavium/cn81xx/Kconfig @@ -30,7 +30,7 @@ default 0x10000

config STACK_SIZE - default 0x2000 + default 8192

config MMCONF_BASE_ADDRESS default 0x848000000000

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Arthur Heymans (Code Review)

3 Oct 3 Oct

8:22 a.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: Kconfig: Change STACK_SIZE value to decimal ......................................................................

Patch Set 2: Code-Review-1

Convert the hex number to decimal in the makefile?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 06:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:15 a.m.

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#3).

Change subject: Kconfig: Change STACK_SIZE value to decimal ......................................................................

Kconfig: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9:16 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#4).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

9:27 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... PS4, Line 20: $(CONFIG_STACK_SIZE) does $(($(CONFIG_STACK_SIZE))) not work?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 07:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:32 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#5).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Arthur Heymans (Code Review)

9:51 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

Patch Set 5:

(1 comment)

Uh my bad.

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... PS4, Line 20: $(CONFIG_STACK_SIZE)

...

does $(($(CONFIG_STACK_SIZE))) not work?

The following should work.

CFLAGS_arm64 += -Wstack-usage=$(shell printf "%d" $(CONFIG_STACK_SIZE))

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 07:51:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:57 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#6).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

10:52 a.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... PS4, Line 20: $(CONFIG_STACK_SIZE)

...

...
does $(($(CONFIG_STACK_SIZE))) not work? […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 08:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6:38 p.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal ......................................................................

Patch Set 6: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG@7 PS6, Line 7: Change nit: Convert?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 16:38:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:29 p.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#7).

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal ......................................................................

soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

7:31 p.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal ......................................................................

Patch Set 7:

(1 comment)

Thank you

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG@7 PS6, Line 7: Change

...

nit: Convert?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 17:31:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com Gerrit-MessageType: comment

Angel Pons (Code Review)

8:39 p.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 03 Oct 2019 18:39:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Oct 4 Oct

6:27 p.m.

New subject: Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal ......................................................................

soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal, since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35593 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/cavium/common/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved

diff --git a/src/soc/cavium/common/Makefile.inc b/src/soc/cavium/common/Makefile.inc index 96e38c3..766c44d 100644 --- a/src/soc/cavium/common/Makefile.inc +++ b/src/soc/cavium/common/Makefile.inc @@ -17,7 +17,8 @@

subdirs-y += pci

-CFLAGS_arm64 += -Wstack-usage=$(CONFIG_STACK_SIZE) +# -Wstack-usage doesn't recognize hexadecimal numbers. +CFLAGS_arm64 += -Wstack-usage=$(shell printf "%d" $(CONFIG_STACK_SIZE))

bootblock-$(CONFIG_BOOTBLOCK_CUSTOM) += bootblock.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/35593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b Gerrit-Change-Number: 35593 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1816

days inactive

1825

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)