Change in coreboot[master]: Kconfig: Change STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: Kconfig: Change STACK_SIZE value to decimal
......................................................................

Kconfig: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/Kconfig
M src/soc/cavium/cn81xx/Kconfig
2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/1

diff --git a/src/Kconfig b/src/Kconfig
index a1c016e..2be653e 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -471,9 +471,9 @@
    default 0x4000

config STACK_SIZE
-	hex
-	default 0x1000 if ARCH_X86
-	default 0x0
+	int
+	default 4096 if ARCH_X86
+	default 0

config MAX_CPUS
    int
diff --git a/src/soc/cavium/cn81xx/Kconfig b/src/soc/cavium/cn81xx/Kconfig
index f64350e..900cade 100644
--- a/src/soc/cavium/cn81xx/Kconfig
+++ b/src/soc/cavium/cn81xx/Kconfig
@@ -30,7 +30,7 @@
    default 0x10000

config STACK_SIZE
-	default 0x2000
+	default 8192

config MMCONF_BASE_ADDRESS
    default 0x848000000000

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: Kconfig: Change STACK_SIZE value to decimal
......................................................................

Patch Set 2: Code-Review-1

Convert the hex number to decimal in the makefile?

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#3).

Change subject: Kconfig: Change STACK_SIZE value to decimal
......................................................................

Kconfig: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/3

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#4).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/4

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
PS4, Line 20: $(CONFIG_STACK_SIZE)
does $(($(CONFIG_STACK_SIZE))) not work?

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#5).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/5

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

Patch Set 5:

(1 comment)

Uh my bad.

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
PS4, Line 20: $(CONFIG_STACK_SIZE)
> does $(($(CONFIG_STACK_SIZE))) not work?

The following should work.

CFLAGS_arm64   += -Wstack-usage=$(shell printf "%d" $(CONFIG_STACK_SIZE))

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#6).

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/6

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
File src/soc/cavium/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef... 
PS4, Line 20: $(CONFIG_STACK_SIZE)
> > does $(($(CONFIG_STACK_SIZE))) not work? […]

Done

Change in coreboot[master]: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................

Patch Set 6: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG@7 
PS6, Line 7: Change
nit: Convert?

Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

Hello Arthur Heymans, Jacob Garber, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35593

to look at the new patch set (#7).

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal
......................................................................

soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/35593/7

Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal
......................................................................

Patch Set 7:

(1 comment)

Thank you

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35593/6//COMMIT_MSG@7 
PS6, Line 7: Change
> nit: Convert?

Done

Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35593 )

Change subject: soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal
......................................................................

soc/cavium/common/Makefile: Convert STACK_SIZE value to decimal

STACK_SIZE value needs to be changed from hex to decimal,
since -Wstack-usage doesn't recognize hexadecimal numbers anymore.

Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35593
Reviewed-by: Angel Pons 
Reviewed-by: Patrick Georgi 
Tested-by: build bot (Jenkins) 
---
M src/soc/cavium/common/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/cavium/common/Makefile.inc b/src/soc/cavium/common/Makefile.inc
index 96e38c3..766c44d 100644
--- a/src/soc/cavium/common/Makefile.inc
+++ b/src/soc/cavium/common/Makefile.inc
@@ -17,7 +17,8 @@

subdirs-y += pci

-CFLAGS_arm64   += -Wstack-usage=$(CONFIG_STACK_SIZE)
+# -Wstack-usage doesn't recognize hexadecimal numbers.
+CFLAGS_arm64   += -Wstack-usage=$(shell printf "%d" $(CONFIG_STACK_SIZE))

bootblock-$(CONFIG_BOOTBLOCK_CUSTOM) += bootblock.c