Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58991 )
Change subject: soc/amd/cezanne/fsp: Set the void_function parameter
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/cezanne/fsp_s_params.c:
https://review.coreboot.org/c/coreboot/+/58991/comment/738f57ea_f184533c
PS3, Line 24: scfg->void_function = (uintptr_t)fsp_s_yield;
What happens if FSP re-inits any of the IP blocks that coreboot is trying to leverage at this point?
Does FSP reconfigure anything in the BSP while it is executing and then put it back before returning control to coreboot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02818987a574f14f790d34f4f0af6b993c520727
Gerrit-Change-Number: 58991
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 22 Nov 2021 19:16:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment