Attention is currently required from: Eran Mitrani, Jérémy Compostella, Kapil Porwal, Shelley Chen, Subrata Banik, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78244?usp=email )
Change subject: soc/intel/mtl: Display Sign-of-Life message using FSP-M
......................................................................
Patch Set 12:
(3 comments)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/78244/comment/374da57f_de7d7c23 :
PS12, Line 468: 1
use the same log as GFX PEIM
```CONFIG(VBOOT_LID_SWITCH) ? get_lid_switch() : CONFIG(RUN_FSP_GOP);```
https://review.coreboot.org/c/coreboot/+/78244/comment/a7e52b35_fbedf8b5 :
PS12, Line 469: VgaMessage
the text alignment logic is part of FSP-M code I assume ?
https://review.coreboot.org/c/coreboot/+/78244/comment/fea4012f_3e28bc5b :
PS12, Line 497: fill_fspm_sign_of_life
```
if (CONFIG(SOC_INTEL_METEORLAKE_SIGN_OF_LIFE))
fill_fspm_sign_of_life(m_cfg, arch_upd);
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78244?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8e7772582b1895fa8e38780932346683be998558
Gerrit-Change-Number: 78244
Gerrit-PatchSet: 12
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 18:32:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment