Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85188?usp=email )
Change subject: soc/mediatek/mt8196: Add MMinfra driver support ......................................................................
Patch Set 27:
(3 comments)
File src/soc/mediatek/mt8196/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/85188/comment/0c1aa1e1_ca15e28d?usp... : PS23, Line 146: VLPCFG_BASE
Upload a separate patch to rename this to `VLP_CFG_BASE`.
please review on 84929.
https://review.coreboot.org/c/coreboot/+/85188/comment/a48722c5_9b6379b3?usp... : PS23, Line 175:
tabs
Done
File src/soc/mediatek/mt8196/mminfra.c:
https://review.coreboot.org/c/coreboot/+/85188/comment/f2eaf80a_8c6dae89?usp... : PS26, Line 110: int ret; : : /* mminfra0 */ : ret = mtcmos_cb_register(MTCMOS_ID_MM_INFRA0, &mm_infra0_pb_cb); : if (ret) : return; : : /* mminfra1 */ : ret = mtcmos_cb_register(MTCMOS_ID_MM_INFRA1, &mm_infra1_pb_cb); : if (ret) : return; : }
Done