Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73262 )
Change subject: mb/google/skyrim/var/winterhold: Use fw_config to probe FP ......................................................................
mb/google/skyrim/var/winterhold: Use fw_config to probe FP
Use fw_config to probe fingerprint.
BUG=b:269986245 TEST=emerge-skyrim coreboot chromeos-bootimage. Test result is pass with 1000 reboot cycles.
Change-Id: I4b4bca42dd78dfd5b8636ff3cb05406d2d0c94f7 Signed-off-by: EricKY Cheng ericky_cheng@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/73262 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Van Patten timvp@google.com --- M src/mainboard/google/skyrim/variants/whiterun/overridetree.cb M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 2 files changed, 37 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Van Patten: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/whiterun/overridetree.cb b/src/mainboard/google/skyrim/variants/whiterun/overridetree.cb index 1b68d9eb..f2d7a75 100644 --- a/src/mainboard/google/skyrim/variants/whiterun/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/whiterun/overridetree.cb @@ -1,4 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later +fw_config + field FP 0 + option FP_ABSENT 0 + option FP_PRESENT 1 + end +end
chip soc/amd/mendocino
@@ -252,7 +258,9 @@ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_12)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" register "enable_delay_ms" = "3" - device generic 0 alias fpmcu on end + device generic 0 alias fpmcu on + probe FP FP_PRESENT + end end end # UART1
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb index 673991e..c9ac6fc 100644 --- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb +++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb @@ -1,4 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later +fw_config + field FP 0 + option FP_ABSENT 0 + option FP_PRESENT 1 + end +end
chip soc/amd/mendocino
@@ -252,7 +258,9 @@ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_12)" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_4)" register "enable_delay_ms" = "3" - device generic 0 alias fpmcu on end + device generic 0 alias fpmcu on + probe FP FP_PRESENT + end end end # UART1